VEX-6011: Align AVOD resolutions with available resolutions on Content #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We need to follow our PR template for RNV PRs. Let's add a link to Jira for this. |
nickfujita
approved these changes
Nov 9, 2021
There was a problem hiding this comment.
nice!
some of these methods are starting to get pretty large. For example, would be nice to split setSelectedTrack into separate methods to handle each selection type. Guess we can handle this at some later point since we need to get this in for the Android deadline
|
Yeah, we should definitely put some work into separating and cleaning up the monolithic file once we do the release 💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for content tracks and improve track selection to work even during ads playback.
Do not merge until Exoplayer logging is disabled!